Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement hss sign schedule function #16789

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: implement hss sign schedule function #16789

wants to merge 2 commits into from

Conversation

lukelee-sl
Copy link
Member

Description:
Implements the signSchedule proxy contract function and the authorizeSchedule function for the Schedule system contract.

Related issue(s):

Fixes #16700

Notes for reviewer:
A future pr will add additional BDD and unit test.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lukelee-sl lukelee-sl added this to the v0.58 milestone Nov 26, 2024
@lukelee-sl lukelee-sl self-assigned this Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.79570% with 16 lines in your changes missing coverage. Please review.

Project coverage is 63.55%. Comparing base (935fdb1) to head (83e1936).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...racts/hss/signschedule/SignScheduleTranslator.java 77.77% 5 Missing and 7 partials ⚠️
...mcontracts/hss/DispatchForResponseCodeHssCall.java 92.00% 1 Missing and 1 partial ⚠️
...rvice/contract/impl/exec/TransactionProcessor.java 66.66% 0 Missing and 1 partial ⚠️
...mpl/exec/scope/HandleSystemContractOperations.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16789      +/-   ##
=============================================
+ Coverage      63.53%   63.55%   +0.02%     
- Complexity     20370    20391      +21     
=============================================
  Files           2537     2537              
  Lines          94746    94829      +83     
  Branches        9902     9914      +12     
=============================================
+ Hits           60198    60273      +75     
+ Misses         30941    30940       -1     
- Partials        3607     3616       +9
Files with missing lines Coverage Δ
...orkflows/handle/dispatch/ChildDispatchFactory.java 91.30% <100.00%> (+0.86%) ⬆️
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...p/service/contract/impl/exec/gas/DispatchType.java 100.00% <100.00%> (ø)
...impl/exec/scope/QuerySystemContractOperations.java 100.00% <100.00%> (ø)
...ract/impl/exec/scope/SystemContractOperations.java 100.00% <ø> (ø)
...t/impl/exec/systemcontracts/HssSystemContract.java 66.66% <ø> (ø)
.../impl/exec/systemcontracts/hss/HssCallAttempt.java 65.21% <100.00%> (+5.21%) ⬆️
.../impl/exec/systemcontracts/hss/HssCallFactory.java 100.00% <100.00%> (ø)
.../contract/impl/state/DispatchingEvmFrameState.java 89.47% <ø> (ø)
...rvice/contract/impl/exec/TransactionProcessor.java 94.38% <66.66%> (+0.12%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes

Impacted file tree graph

@codacy-production Codacy Production
Copy link

codacy-production bot commented Nov 26, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.03% (target: -1.00%) ✅ 92.47%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (935fdb1) 97511 63616 65.24%
Head commit (83e1936) 97594 (+83) 63700 (+84) 65.27% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16789) 93 86 92.47%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

stoyanov-st
stoyanov-st previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, ty @lukelee-sl !
Left a few suggestions for improvement but all up to you

...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java Outdated Show resolved Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ContractsConfig.java Show resolved Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java Show resolved Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java Show resolved Hide resolved
@lukelee-sl
address pr comments
83e1936 
Signed-off-by: Luke Lee <[email protected]>
stoyanov-st
stoyanov-st approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoyanov-st stoyanov-st stoyanov-st approved these changes

@tinker-michaelj tinker-michaelj Awaiting requested review from tinker-michaelj tinker-michaelj is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@lukelee-sl lukelee-sl

Labels
None yet
Projects
None yet
Milestone
v0.58
Development

Successfully merging this pull request may close these issues.

Implement translator and call classes for signSchedule and authorizeSchedule functions
2 participants
@lukelee-sl @stoyanov-st